Add support for loading mpq archives from buffers#8
Open
alardev wants to merge 9 commits intowowemulation-dev:mainfrom
Open
Add support for loading mpq archives from buffers#8alardev wants to merge 9 commits intowowemulation-dev:mainfrom
alardev wants to merge 9 commits intowowemulation-dev:mainfrom
Conversation
20 tasks
Signed-off-by: Alaro <glooriouswalrus@protonmail.com>
Member
|
@alardev let me know if I can help. Looks like a good start though. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Alaro <glooriouswalrus@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Changes Made
Added a method for Archive struct that allows loading archive files from a buffer of
Vec<u8>.Related Issues
Fixes #7
Closes #7
Related to #7
Testing
Test Cases Added/Modified
Test Results
Tested On
WoW Versions Tested
Quality Assurance
Code Quality
Required Checks
cargo fmt --all- Code is formattedcargo clippy --all-targets --all-features- No clippy warningscargo test --all-features- All tests passcargo test --no-default-features- Tests pass without featurescargo deny check- No security/license issuesCompatibility
Documentation
docs/Benchmarks
Performance Impact
Benchmark Results
Breaking Changes
API Changes
Migration Guide
Security Considerations
Additional Context
Dependencies
Known Limitations
Screenshots/Examples
Reviewer Notes
Areas of Focus
Questions for Reviewers
By submitting this PR, I confirm that: