Fix typo in Registry.EM_COMMON and README.namelist (Xiananjiang to Xinanjiang)#2289
Fix typo in Registry.EM_COMMON and README.namelist (Xiananjiang to Xinanjiang)#2289andrewsoong wants to merge 5 commits intowrf-model:developfrom
Conversation
…WRITE statement (wrf-model#2265) TYPE: bug fix KEYWORDS: time series, TS, format, write, wrf solar, solar_diagnostics SOURCE: Massimo D'Isidoro (ENEA - Italian National Agency for New Technologies, Energy and Sustainable Economic Development) DESCRIPTION OF CHANGES: Problem: When solar diagnostics is activated in namelist.input, the WRF time series output WRITE statement lists 55 variables but the Fortran FMT only specifies 54 fields. This causes the last variable (ts_swddnic2) to be written in a separate record in the output files *.TS , leading to inconsistent time series data. Solution: The WRITE statement FMT has been corrected to match all 55 variables, ensuring that they are written on the same record in the TS file. ISSUE: This fixes part of issue wrf-model#2255 LIST OF MODIFIED FILES: M share/wrf_timeseries.F TESTS CONDUCTED: 1. A WRF run with solar_diagnostics activated, compared to previous version to confirm the fix. 2. The regression tests have passed. RELEASE NOTE: Corrected a bug in the WRF time series output, when solar_diagnostics is activated, where the last variable (ts_swddnic2) was written in a separate record. TS files now correctly includes all the 55 variables on the same record.
TYPE: text only KEYWORDS: WRF, diagnostics, WetBulbTemp, unit label, dewpoint, documentation SOURCE: Yuxuan Xie (IGSNRR, CAS) DESCRIPTION OF CHANGES: Problem: The WetBulbTemp utility variable tdC was documented with the wrong unit (K) in a comment, inconsistent with its Celsius usage. Solution: Update the unit in the comment to C in phys/module_diag_functions.F. LIST OF MODIFIED FILES: M phys/module_diag_functions.F RELEASE NOTE: Corrected the WetBulbTemp dewpoint temperature unit label to Celsius in comments.
Fix typo(Xiananjiang to Xinanjiang)
Fix typo(Xiananjiang to Xinanjiang)
dudhia
dismissed stale reviews from weiwangncar and themself
The base branch was changed.
dudhia
left a comment
dudhia
left a comment
There was a problem hiding this comment.
Changed base to develop.
dudhia
left a comment
dudhia
left a comment
There was a problem hiding this comment.
when resolving the conflict it reverted to the mistyped name because opt_run does not exist in the new NoahMP version.
|
@dudhia @andrewsoong opt_run in the latest NoahMP update has been changed to two options: opt_runsrf and opt_runsub. Both have the misspell in them. |
Thanks @weiwangncar |
5 participants
TYPE: text only
KEYWORDS: WRF, NOAH-MP, Xinanjiang scheme
SOURCE: Haiqing SONG (宋海清) Ecological and Agricultural Meteorology Center of Inner Mongolia &
Inner Mongolia Meteorological Satellite Remote Sensing Center, China
DESCRIPTION OF CHANGES:
Update the typo in Registry.EM_COMMON and README.namelist (Xiananjiang to Xinanjiang)
LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)
M run/README.namelist
M Registry/Registry.EM_COMMON