Align docs with current color API #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation to align with the current color API implementation and fixes incorrect conditional compilation directives.
- Updates README with correct repository URLs and current API usage patterns
- Corrects conditional compilation comment from
canImport(SwiftUI)toos(OSX)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates repository links and API examples to reflect current implementation |
| Sources/WrkstrmColor/Color+Extensions.swift | Fixes conditional compilation comment for NSColor extension |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| } | ||
| #endif // canImport(SwiftUI) | ||
| #endif // os(OSX) |
There was a problem hiding this comment.
The conditional compilation comment should match the actual directive being used. Since the code extension is for NSColor which is typically available on macOS, the comment should reflect the actual compilation condition (likely canImport(AppKit) or similar) rather than the deprecated os(OSX) identifier.
Suggested change
| #endif // os(OSX) | |
| #endif // canImport(AppKit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Color+ExtensionsTesting
swift testhttps://chatgpt.com/codex/tasks/task_e_68ad724af158833393fed927a853a5e9