Revert "skip filtering federated apis"

[nisan-abeywickrama]

Reverts #597

Summary by CodeRabbit

Bug Fixes

• API filtering is now more restrictive and accurate, which may affect which APIs are accessible in your environment.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The filtrerAllowedAPIs function in src/utils/util.js has been simplified. Previously, it allowed APIs to pass through if their apiReferenceID matched an allowed API's id OR if they had a gatewayVendor in the allowed APIs list. The gateway vendor bypass condition has been removed, so now only the apiReferenceID matching condition is applied.

Changes

Cohort / File(s)	Summary
Logic simplification src/utils/util.js	Simplified filtrerAllowedAPIs to remove gateway vendor bypass logic; now only filters APIs based on apiReferenceID matching

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file modification with straightforward logic removal
• No new complexity or architectural changes introduced
• Function behavior change is localized and easy to verify

Poem

🐰 A gateway's bypass fades away,
Simpler paths now light the day,
No vendor tricks to slip on through—
Just matching IDs, pure and true! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is minimal and only references the issue being reverted. It lacks nearly all required template sections including purpose, goals, approach, user stories, release notes, and other critical information.	Provide a comprehensive description following the template: include Purpose (why revert), Goals (expected outcomes), Approach, User stories, Release notes, and other applicable sections. At minimum, explain the rationale for reverting this change.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: reverting a previous commit that skipped filtering federated APIs. It is clear, specific, and accurately reflects the code modification.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch revert-597-main

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98aa7c9 and dd8c6ee.

📒 Files selected for processing (1)

• src/utils/util.js

🔇 Additional comments (1)

src/utils/util.js (1)

914-920: Verify that federated APIs have matching apiReferenceID values in the control plane's allowed list.

This revert removes federated API filtering bypass logic. The filterAllowedAPIs function now filters all APIs strictly by apiReferenceID matching against the control plane's allowed list. Federated APIs (those with gatewayVendor in FEDERATED_GATEWAY_VENDORS) will no longer bypass this filter, so they must have matching entries in the control plane's API list. Confirm that federated APIs (currently only 'aws' vendor) are properly registered in the control plane with corresponding apiReferenceID values, otherwise they will be filtered out from search results and become inaccessible.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}