Conversation
WalkthroughA Helm chart values file is updated to bump image tags for two components from pre-release SNAPSHOT versions to stable release versions (0.9.0), enabling deployment of finalized builds. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@kubernetes/helm/gateway-helm-chart/values.yaml`:
- Line 300: Update all leftover "0.9.0-SNAPSHOT" references to "0.9.0" so the
chart and images are consistent: change Chart.yaml appVersion from
"0.9.0-SNAPSHOT" to "0.9.0", update the image tags for gateway-controller and
gateway-runtime in gateway/docker-compose.yaml, and update the version fields in
gateway/build.yaml and gateway/sample-policies/build.yaml to "0.9.0"; ensure
Chart.yaml appVersion exactly matches the tag in
kubernetes/helm/gateway-helm-chart/values.yaml to satisfy the
gateway-helm-release.yml CI check.
| image: | ||
| repository: ghcr.io/wso2/api-platform/gateway-controller | ||
| tag: "0.9.0-SNAPSHOT" | ||
| tag: "0.9.0" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's confirm the values.yaml file content at lines 300 and 441
cat -n kubernetes/helm/gateway-helm-chart/values.yaml | sed -n '298,302p;439,443p'Repository: wso2/api-platform
Length of output: 413
🏁 Script executed:
# Search for remaining 0.9.0-SNAPSHOT references
rg "0\.9\.0-SNAPSHOT" --type yaml --type dockerfileRepository: wso2/api-platform
Length of output: 95
🏁 Script executed:
# Check the gateway/it/docker-compose.test.yaml file mentioned in learnings
cat -n gateway/it/docker-compose.test.yamlRepository: wso2/api-platform
Length of output: 9574
🏁 Script executed:
# Search for all references to gateway-controller and gateway-runtime images in the repo
rg "gateway-controller|gateway-runtime" --type yaml --type dockerfile | head -30Repository: wso2/api-platform
Length of output: 95
🏁 Script executed:
# Search for remaining 0.9.0-SNAPSHOT references (correct syntax)
rg "0\.9\.0-SNAPSHOT" --type yamlRepository: wso2/api-platform
Length of output: 436
🏁 Script executed:
# Find all image references to gateway-controller and gateway-runtime
rg "gateway-controller|gateway-runtime" --type yaml | head -50Repository: wso2/api-platform
Length of output: 6576
🏁 Script executed:
# Check CI workflow files for image references
find .github -name "*.yml" -o -name "*.yaml" | xargs grep -l "gateway-controller\|gateway-runtime" 2>/dev/nullRepository: wso2/api-platform
Length of output: 395
🏁 Script executed:
# Search for any SNAPSHOT tag references in yaml files to catch if there are other versions
rg "SNAPSHOT" --type yaml | grep -i "gateway\|image\|tag"Repository: wso2/api-platform
Length of output: 742
🏁 Script executed:
# Check if these stale SNAPSHOT files are in the current PR/changes
# Let's see what files were modified
git diff --name-only HEAD~1 HEAD 2>/dev/null || git status --shortRepository: wso2/api-platform
Length of output: 43
🏁 Script executed:
# Check the Chart.yaml appVersion field
cat -n kubernetes/helm/gateway-helm-chart/Chart.yaml | head -20Repository: wso2/api-platform
Length of output: 607
🏁 Script executed:
# Check gateway/docker-compose.yaml for the SNAPSHOT references
cat -n gateway/docker-compose.yaml | grep -A2 -B2 "gateway-controller\|gateway-runtime"Repository: wso2/api-platform
Length of output: 1472
🏁 Script executed:
# Inspect one of the CI workflow files for hardcoded image versions
cat kubernetes/helm/gateway-helm-chart/.github/workflows/gateway-helm-release.yml 2>/dev/null || cat .github/workflows/gateway-helm-release.yml | head -100Repository: wso2/api-platform
Length of output: 3434
Address stale SNAPSHOT references in parallel files
The values.yaml tag bumps to 0.9.0 are correct, but the PR is incomplete. Several files still reference 0.9.0-SNAPSHOT and should be updated in the same commit:
- kubernetes/helm/gateway-helm-chart/Chart.yaml (line 6): appVersion still "0.9.0-SNAPSHOT"
- gateway/docker-compose.yaml (lines 21, 50): gateway-controller and gateway-runtime still reference 0.9.0-SNAPSHOT
- gateway/build.yaml: version still 0.9.0-SNAPSHOT
- gateway/sample-policies/build.yaml: version still 0.9.0-SNAPSHOT
The CI workflow gateway-helm-release.yml validates that Chart.yaml appVersion matches the image tags in values.yaml, so the Chart.yaml mismatch will cause release failures.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@kubernetes/helm/gateway-helm-chart/values.yaml` at line 300, Update all
leftover "0.9.0-SNAPSHOT" references to "0.9.0" so the chart and images are
consistent: change Chart.yaml appVersion from "0.9.0-SNAPSHOT" to "0.9.0",
update the image tags for gateway-controller and gateway-runtime in
gateway/docker-compose.yaml, and update the version fields in gateway/build.yaml
and gateway/sample-policies/build.yaml to "0.9.0"; ensure Chart.yaml appVersion
exactly matches the tag in kubernetes/helm/gateway-helm-chart/values.yaml to
satisfy the gateway-helm-release.yml CI check.
Purpose
Summary by CodeRabbit