Skip to content

⚡ Optimize admin view: Fix N+1 query on fetching answers #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xRahul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Optimize admin view: Fix N+1 query on fetching answers #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions quiz_system_git/admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,9 +986,28 @@
$stmt->execute(['quizID' => $get_quiz_id]);
}

$all_questions = $stmt->fetchAll();

// Gather all question IDs
$question_ids = [];
foreach ($all_questions as $q) {
$question_ids[] = $q['question_id'];
}

// Fetch all answers in one go
$answers_map = [];
if (!empty($question_ids)) {
$placeholders = implode(',', array_fill(0, count($question_ids), '?'));
$stmtAns = $pdo->prepare("SELECT * FROM answers WHERE question_id IN ($placeholders)");
$stmtAns->execute($question_ids);
while ($row = $stmtAns->fetch()) {
$answers_map[$row['question_id']][] = $row;
}
}

$m_display_ID = 1;

while($m_row = $stmt->fetch()){
foreach($all_questions as $m_row){
$m_answers='';
//id var = id column and so on
$m_id = $m_row['id'];
Expand Down Expand Up @@ -1031,25 +1050,24 @@
}

//gathering answers of question here
$stmtAns = $pdo->prepare("SELECT * FROM answers WHERE question_id=:questionID");
$stmtAns->execute(['questionID' => $m_question_id]);

$m_answers .= '<tr>
<td></td>
<td>
<ol type="a">
';

while($m_row2 = $stmtAns->fetch()){
//putting column values in variables
$m_answer = $m_row2['answer'];
$m_correct = $m_row2['correct'];

if($m_correct == 1)
$m_answers .= '<u><i>';
$m_answers .= '<div style="width: 730px; word-wrap: break-word;"><li>'.$m_answer.'</li></div>';
if($m_correct == 1)
$m_answers .= '</i></u>';
if (isset($answers_map[$m_question_id])) {
foreach($answers_map[$m_question_id] as $m_row2){
//putting column values in variables
$m_answer = $m_row2['answer'];
$m_correct = $m_row2['correct'];

if($m_correct == 1)
$m_answers .= '<u><i>';
$m_answers .= '<div style="width: 730px; word-wrap: break-word;"><li>'.$m_answer.'</li></div>';
if($m_correct == 1)
$m_answers .= '</i></u>';
}
}

$m_answers .= ' </ol>
Expand Down