This repository was archived by the owner on May 1, 2024. It is now read-only.
Fix "supermarket" missing from PlaceTypes#402
Open
breyed wants to merge 1 commit intoxamarin:mainfrom
Open
Conversation
Fixes xamarin#401. This is a breaking change: the type of `Google.Places.Types` is changed from `PlaceType[]` to `string[]`.
Author
|
Report for bug in Google SDK: No constant for "supermarket" place type |
Author
|
For consistency, if this PR is implemented, In |
Contributor
|
@breyed Thanks for your contribution and thanks for linking to the right docs! Breaking changes are bad for everyone. Let me check the code to see if there's a way to avoid the pain. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401. This is a breaking change: the type of
Google.Places.Typesis changed fromPlaceType[]tostring[].Advantages:
supermarketin the supported types, but does not include it in GMSPlaceType.Places.TypesthrowingNotSupportedException.Disadvantages:
If the PR is implemented,
PlaceTypeshould be removed, as it is no longer uses, and the documentation should be updated to link to the supported types.