Change string_to_intmax() and string_to_uintmax()#48
Merged
xexyl merged 1 commit intoxexyl:masterfrom Nov 1, 2025
Merged
Conversation
to use `warn(3)` so that the `test_ioccc/txzchk_test.sh` from [the other repo](https://github.com/ioccc-src/mkiocccentry) won't trigger a test error due to system implementation differences with various `errno` values. Updated `JPARSE_REPO_VERSION` to "2.5.1 2025-10-31". Updated `JPARSE_UTILS_VERSION` to "2.1.6 2025-10-31". Ran `make release` to test the above.
lcn2
added a commit
to ioccc-src/mkiocccentry
that referenced
this pull request
Nov 1, 2025
The `test_ioccc/txzchk_test.sh` test for the bad test `submit.12345678-1234-4321-abcd-1234567890ab-7.1761934326.txt` no longer depends on the `errno` strings. Modified `jparse/util.c` (see in the other repo, [jparse PR 48](xexyl/jparse#48)) to use `warn(3)` instead of `warnp(3)` to avoid the system depending errno string. Ran `make release` to test the above. TODO: In regards to what `test_ioccc/txzchk_test.sh` tests: Look over the additional bad tests to be sure that the test results are OK. Review: `submit.12345678-1234-4321-abcd-1234567890ab-8.1761934327.txt.err` Is the "_Warning: string_to_intmax: error converting string_" the best way to handle "super-bogus" lengths? Maybe it is OK?
Owner
|
Thank you Landon. I only just saw this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to use
warn(3)so that thetest_ioccc/txzchk_test.shfrom the other repo won't trigger a test error due to system implementation differences with variouserrnovalues.Updated
JPARSE_REPO_VERSIONto "2.5.1 2025-10-31". UpdatedJPARSE_UTILS_VERSIONto "2.1.6 2025-10-31".Ran
make releaseto test the above.