Skip to content

refactor(etcd): replace kine with native etcd client#393

Closed
xiaods wants to merge 8 commits intomainfrom
dev
Closed

refactor(etcd): replace kine with native etcd client#393
xiaods wants to merge 8 commits intomainfrom
dev

Conversation

@xiaods
Copy link
Owner

@xiaods xiaods commented Jun 8, 2025

vibe coding for Feature: finetune storage client without kine, use native embed etcd client. #315

vibe coding for Feature: finetune storage client without kine, use native embed etcd client. #315
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025

Unit Test Results

278 tests   261 ✔️  1m 4s ⏱️
102 suites      0 💤
    1 files        2   15 🔥

For more details on these failures and errors, see this check.

Results for commit 6d169bd.

♻️ This comment has been updated with latest results.

xiaods added 7 commits June 8, 2025 23:43
…rove encryption configuration handling**

- Added support for the SecretBox encryption provider, alongside the existing AESCBC provider
- Refactored encryption configuration generation logic to be more modular and support multiple encryption methods
- Improved encryption key management by introducing the `EncryptionKeys` struct to uniformly manage different keys
- Added the `streaming-bind-addr` configuration to cri-dockerd
- Renamed `cateRenewDays` to `CertificateRenewDays` for better readability
- Optimized the encryption configuration hash generation algorithm while maintaining backward compatibility
- Added `SocketOpts` to enable address and port reuse
- Fixed pointer passing issue in `ETCDConfig`
…issues

- Add error wrapping in agent.go to provide clearer error messages
- Skip reapplying unchanged log configurations
- Move GetArgs function call from daemonconfig to util package
- Add type check for runtime.Core in tlsStorage function
- Add `EtcdSnapshotReconcile` field to Control struct for configuring etcd snapshot reconciliation interval
- Remove old `etcd_test.go` and create new `etcd_linux_test.go`
- Refactor all etcd-related test cases to support snapshot reconciliation testing
…up logic

Add pkg/cluster/etcd_client.go to implement native ETCD client wrapper
Refactor cluster startup flow, separate listener service and data store initialization
Improve ETCD config management to support direct native ETCD client parameters
Optimize bootstrap data storage and migration logic
Add TLS configuration support for secure ETCD communication
Remove DisableServiceLB check in server.go and directly disable the service controller
Update test comments in unit.go, correcting "/var/lib/k8e" to "/var/lib/rancher/k8e"
Modify GenerateRuntime function to retain the existing runtime's ready channel
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
14.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@xiaods
Copy link
Owner Author

xiaods commented Jun 10, 2025

Oops, I can't afford this buggy workflow, let me reset and vibe again coding.

@xiaods xiaods closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments