Conversation
Remove the experimental KineTLS flag and all Kine‑related imports Add TLSConfig and ETCDConfig structs to hold datastore and runtime connection settings Update startStorage to configure etcd endpoints directly without Kine Remove SQLite migration code and related endpoint handling Adjust config types to use the new structs and drop KineTLS field
Contributor
Test Results274 tests 274 ✅ 4m 16s ⏱️ Results for commit 5dbfae7. ♻️ This comment has been updated with latest results. |
Rename architecture diagram files into docs/assets Add KIP documenting the native embedded etcd storage client Replace kine storage layer with a lightweight clientv3 wrapper and delete kine dependency
Set the Zig target ABI to “musl” when the OS tag is Linux, otherwise use the original ABI tag. Reformat the `k8e_binaries` array for clearer alignment.
Add mkdir for build/static so the directory is created during packaging. Ensure the script ends with a trailing newline.
Introduce build steps for containerd-shim-runc-v2 and runc, set up environment variables, and add a goarch_str helper used by Go binary builds.
Include build date in version information and create the bin directory before building binaries. Expand ldflags to embed comprehensive version data and add a new step that clones, builds, and installs the CNI plugins. The clean target now also removes the CNI build directory.
Introduce constants for package paths and a `buildRoot` helper. Add a `VersionInfo` struct and `buildVersionFlags` function to generate a single ldflags string used by all Go binaries. Remove duplicated environment handling and replace hard‑coded build root paths with the new `root` variable. Update shim and CNI plugin builds to use the shared ldflags and the unified root path.
Drop the explicit CC environment variable for the runc build step and reduce extldflags to '-static' only, removing unnecessary libraries.
Removed separate EXTRA_LDFLAGS and BUILDTAGS environment variables and added them to the runc make command arguments together with the static flag.
Build libseccomp as a static library and link it into runc for seccomp support. Extend the clean target to also remove the .libseccomp directory.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.