Skip to content

Bcast xtrue to non-root ranks#126

Open
rayegun wants to merge 1 commit intoxiaoyeli:masterfrom
rayegun:fixexample
Open

Bcast xtrue to non-root ranks#126
rayegun wants to merge 1 commit intoxiaoyeli:masterfrom
rayegun:fixexample

Conversation

@rayegun
Copy link

@rayegun rayegun commented Oct 31, 2022

I believe this is correct, I haven't run it though. This should fix the issue we faced with xtrue being different when the number of ranks are > 1.

@xiaoyeli
Copy link
Owner

xiaoyeli commented Nov 2, 2022

This is a good suggestion. Your patch has a small error: P0 (root) should also participate in MPI_Bcast().
Instead of merging your PR, I updated the macro files that generate all the pdrive_ABglobal.c, with 3 precisions and 4 different example drivers. They are pushed in master branch on github.

You can close this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants