Fix openmp build failures with Cray compiler.#50
Open
bavier wants to merge 1 commit intoxiaoyeli:masterfrom
Open
Fix openmp build failures with Cray compiler.#50bavier wants to merge 1 commit intoxiaoyeli:masterfrom
bavier wants to merge 1 commit intoxiaoyeli:masterfrom
Conversation
The 'lastprivate' clause here causes a build failure with the Cray compiler:
CC-1653 craycc: ERROR File = ./SRC/pzgstrs_lsum.c,
Line = 1171
The variable "irow" cannot be used in this lastprivate clause
because the variable appears in a conflicting clause in an enclosing
region.
#pragma omp simd lastprivate(irow)
^
Since the `irow` variable is not used later in the enclosing taskloop, its
value is irrelevant, so just leave out the 'lastprivate' clause.
* SRC/pdgstrs_lsum.c (dlsum_fmod_inv_master): Remove lastprivate clause.
* SRC/pzgstrs_lsum.c (zlsum_fmod_inv_master): Ditto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'lastprivate' clause here causes a build failure with the Cray compiler:
CC-1653 craycc: ERROR File = ./SRC/pzgstrs_lsum.c,
Line = 1171
The variable "irow" cannot be used in this lastprivate clause
because the variable appears in a conflicting clause in an enclosing
region.
#pragma omp simd lastprivate(irow)
^
Since the
irowvariable is not used later in the enclosing taskloop, itsvalue is irrelevant, so just leave out the 'lastprivate' clause.