update instructor for sentence transformers#129
Open
BBC-Esq wants to merge 11 commits intoxlang-ai:mainfrom
Open
update instructor for sentence transformers#129BBC-Esq wants to merge 11 commits intoxlang-ai:mainfrom
BBC-Esq wants to merge 11 commits intoxlang-ai:mainfrom
Conversation
refactor: few updates to have the functionality on-par with sentence-transformers and other minor updates
Necessary because sentence transformers is now using the "backend" parameter when instantiating a model and the passing of "module_kwargs = {}" due to recent changes with sentence transformers.
Forgot to make whether to return "module_kwargs = {}" also conditional on if a user is using an older or newer version of sentence transformers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary because sentence transformers is now using the "backend" parameter when instantiating a model and the passing of "module_kwargs = {}" due to recent changes with sentence transformers.
This differs from the following two other pull requests that attempt to address the same issue, as outlined below...but the core unique feature of mine is that it's backward compatible with older versions of the
sentence-transformerslibrary:inspect.signature()to check if backend parameter exists at runtimebackend: Literal['torch', 'onnx', 'openvino'] = 'torch'backend: str = "torch"_load_modelEdit
My 1/29/2025 commit is necessary because my prior modifications failed to address the new
is_peft_modelparameter thatsentence-transformershas implemented. Everything should work fine now.