openshift log output on exception

[laDok8]

issue: issue
Adding optional Openshift pod/build and event logs into test failure message.

Please make sure your PR meets the following requirements:

• Pull Request contains a description of the changes
• Pull Request does not include fixes for multiple issues/topics
• Code is formatted, imports ordered, code compiles and tests are passing
• Code is self-descriptive and/or documented

[mchoma]

Have you considered Service Log Stream [1] for implementing this feature? Logic would be different to current implementation. Stream to some temporary place (e.g. into String) and once test failes flush that String to System.err.

• Advantages:

  • cronological order
  • all log there. When storing on end some containers can be gone by restarts.

• Disadvantage are:

  • there are no events.
  • maybe chronological order is not important so much for computer pattern searching

[1] https://github.com/xtf-cz/xtf/blob/master/README.md?plain=1#L160

[laDok8]

i think having having all logs is not as important as i'm already filtering only for warning/error messages and pod causing exception should be active at that time so we should have all important info. WDYT @istraka

[mnovak]

I think there is problem when 2 test in single test case fail as in:
https://jenkins.eapqe.psi.redhat.com/job/eap-8.x-openshift-4-74/285/

Only the first one has attached logs in JUnit report but not the second one:
https://jenkins.eapqe.psi.redhat.com/job/eap-8.x-openshift-4-74/285/testReport/junit/com.redhat.xpaas.eap.smoke/SmokeTest/badAssertTest/
https://jenkins.eapqe.psi.redhat.com/job/eap-8.x-openshift-4-74/285/testReport/junit/com.redhat.xpaas.eap.smoke/SmokeTest/throwExceptionTest/

[jbliznak]

please be aware of the same problem fixed in #521