Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 436b050083
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| while True: | ||
| pass |
There was a problem hiding this comment.
This while True: pass loop will spin at 100% CPU indefinitely on the Pi, which can starve the rest of the system and degrade audio/IO responsiveness. If the intent is to keep the process alive, insert a sleep or a blocking event loop so the main thread yields CPU.
Useful? React with 👍 / 👎.
| sudo apt install -y \ | ||
| mpd mpc \ | ||
| # bluez bluealsa bluealsa-aplay \ | ||
| # camilladsp \ | ||
| python3 python3-pip python3-venv \ |
There was a problem hiding this comment.
The line continuation ends before the commented package lines, so the apt install command stops after mpd mpc, and the next line starting with python3 runs as a separate command (and fails under set -e). On a clean install this causes the installer to abort before installing dependencies. Keeping the backslash on the last non-comment line or moving comments above the command avoids the premature termination.
Useful? React with 👍 / 👎.
scripts/clone_repo.sh
Outdated
| else | ||
| git clone https://github.com/<repo>/streamer.git |
There was a problem hiding this comment.
The clone command uses https://github.com/<repo>/streamer.git, which is a placeholder and will always fail. As written, a fresh installation cannot fetch the project and will stop here.
Useful? React with 👍 / 👎.
scripts/install_python.sh
Outdated
|
|
||
| echo "[install_python] Instaluję biblioteki Python..." | ||
|
|
||
| pip3 install RPi.GPIO smbus2 pillow mpd2 |
There was a problem hiding this comment.
The UI display module imports luma.core/luma.oled, but the installer only installs RPi.GPIO smbus2 pillow mpd2. On a clean install this leads to ImportError: No module named 'luma' when ui/display.py is imported. Add the luma packages to the install step to avoid startup failure.
Useful? React with 👍 / 👎.
1 participant
No description provided.