forked from ILIAS-eLearning/ILIAS
-
Notifications
You must be signed in to change notification settings - Fork 0
Ilias 6.0 Universität Hannover #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xus
wants to merge
71
commits into
trunk
Choose a base branch
from
6_0_uhannover_A18T348
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
2cf4503
Compare submission first implementation
xus 697fe02
missing parenthesis
xus c93a2e5
Fix filter feedback
xus a2ee6b5
changes in Feedback filter constants
xus 72aab7b
Refactor: avoid duplicate code when gathering data from reviews
xus bcd6772
tpl for group of panels with the proper title. (members and compare l…
xus 8e6cd45
Fixed and customized the mail notification for comments on wikis.
xus 5a4eef6
language variables
xus e1d3423
Firsts steps for LM comments notifications
xus a8d339b
Implement notifications for learning modules when new comment
xus 1791ca8
Merge branch 'trunk_compare_text_submissions' into 6_0_uhannover_A18T348
xus 7ed0f02
Merge branch '6_0_notifications_wikis_lm' into 6_0_uhannover_A18T348
xus c8d3d8b
missing german lang vars
xus 9def6fe
set send method public
xus 23e0190
typos
xus 78d73ee
Fix wiki comment action
xus 48d23fa
Fix LM comment on page notification
xus cdebf4d
Add ilLearningModuleNotification to autoload.
xus ce7eb22
method descriptions and remove comments
xus 6c09eff
Exc global setting to accept versioning for submissions
xus 887d3a2
Versioning table column to exc assignments type text if enabled
xus dcca5e2
submission versionables. GUI table + db + lang
xus 1398582
submission isVersioned + show action buttons depending if submit version
xus 8cdc921
do not show version 0 in the gui table
xus 0bc1cf1
ilSubmission canSubmit returns true also when the submission has bee…
xus cba445a
btns+lang User can send more than one submission
xus 8ffb9c5
Edit the last revision
xus b9867ed
isVersionable if no versioned before or last version is 0
xus 6c2520a
DB update + reload structure
xus 5a6a28e
remove DB update
xus d2e217e
Refactor to get versions in one DB table.
xus ce34a77
msg when successfully freeze a submission
xus fa6115a
get member assignment data can return an empty array
xus 06dc877
showSubmissionPanel to display all panel lists
xus 4ec4783
small fix for filter in panels list
xus 21fd01e
Add Status time info for the versioned cards + lang vars
xus 1b9605f
Customize panels to get revision or submission information
xus 8c268ad
List versions DESC
xus b7ee49a
Confirmation form before freeze submission
xus d405fd0
Notification when submission has been frozen
xus b6ef8f2
missing english lang var
xus e09edff
Refactoring: Everything related with the panels list moved to a handl…
xus 304c13f
executeCommand new panelshandler with user id + set return + remove u…
xus 53fc759
Fix ilctrl navigation and set current user if in assignment view.
xus 2b99075
Toolbar on members: remove second formAction
xus 3dbe094
Fixing the back to previous view
xus d40f277
just add the custom db update file
xus 4ea360d
remove changes in main db file
xus 91723b5
LM notifications when edit
xus 7b92bdf
[Fix 24825] Wiki notification- No content when comment
xus 6e84a14
Fix indentation
xus 09a6ccc
Fix notification for lm page
xus 28c4150
remove todo
xus bbf8b32
LM notification with content when edit.
xus 11736d7
add changes to german lang file
xus 7dac9d3
Fix comment action + lang files
xus 8dcc54d
lm constants to define the actions
xus 55d6c4a
Fix participant view tab
xus aa97d60
[Fix 24850 part 1] Implement grade/evaluate revisions
xus 30ef0a0
[Fix 24850 Part2] Grade and evaluate revisions
xus a77223c
[Fix 24850 end] new db field for feedback date + db fixes
xus c5b157c
Missing lang var
xus 42b5a7d
Remove return types when null allowed.
xus e2503e2
Remove more Return type declarations
xus daa64dd
lm and wiki comments via modalbox send notification
xus fd68663
Refactoring - versionable: Use of ilExAssignmentTypes
xus 44395f8
Revert "Refactoring - versionable: Use of ilExAssignmentTypes"
xus b0f1579
[Fix 25050] No freeze submission option if there is no submission
xus ecf139f
[Fix 25049] column version just before status
xus 9e016c0
[Fix 25051] Freeze/d submissions as second position in the dropdown
xus b519d71
[Fix 25049-2part] move version in members row html
xus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,8 +14,6 @@ class ilExSubmission | |
| const TYPE_TEXT = "Text"; | ||
| const TYPE_REPO_OBJECT = "RepoObject"; // Wikis | ||
|
|
||
|
|
||
|
|
||
| /** | ||
| * @var ilObjUser | ||
| */ | ||
|
|
@@ -201,7 +199,8 @@ public function getSelectedObject() | |
| public function canSubmit() | ||
| { | ||
| return ($this->isOwner() && | ||
| $this->state->isSubmissionAllowed()); | ||
| $this->state->isSubmissionAllowed() || | ||
| $this->isVersioned()); | ||
| } | ||
|
|
||
| public function canView() | ||
|
|
@@ -523,8 +522,13 @@ function getFiles(array $a_file_ids = null, $a_only_valid = false, $a_min_timest | |
| if($a_min_timestamp) | ||
| { | ||
| $sql .= " AND ts > ".$ilDB->quote($a_min_timestamp, "timestamp"); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| if($this->isVersioned()) | ||
| { | ||
| $sql .= " ORDER BY returned_id DESC LIMIT 1"; | ||
| } | ||
|
|
||
| $result = $ilDB->query($sql); | ||
|
|
||
| $delivered_files = array(); | ||
|
|
@@ -654,6 +658,30 @@ public static function findUserFiles($a_user_id, $a_filetitle) | |
| } | ||
| return $res; | ||
| } | ||
|
|
||
| /** | ||
| * Return the submission ids related to the specific user and assignment | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not only IDS |
||
| * @param $a_user_id | ||
| * @param $a_filetitle | ||
| * @return array | ||
| */ | ||
| public function getSubmissionsByUser() : array | ||
| { | ||
| $sql = "SELECT *". | ||
| " FROM exc_returned". | ||
| " WHERE user_id = ".$this->db->quote($this->user_id, "integer"). | ||
| " AND ass_id = ".$this->db->quote($this->assignment->getId(), "integer"); | ||
|
|
||
| $set = $this->db->query($sql); | ||
|
|
||
| $res = array(); | ||
| while($row = $this->db->fetchAssoc($set)) | ||
| { | ||
| $res[] = $row; | ||
| } | ||
|
|
||
| return $res; | ||
| } | ||
|
|
||
| function deleteAllFiles() | ||
| { | ||
|
|
@@ -1666,5 +1694,15 @@ static function getDirectoryNameFromUserData($a_user_id) | |
|
|
||
| return $targetdir; | ||
| } | ||
|
|
||
| /** | ||
| * Check if the submission has been versioned by tutor/admin | ||
| * @return bool | ||
| */ | ||
| public function isVersioned() : bool | ||
| { | ||
| $revision = new ilExSubmissionRevision($this); | ||
| return $revision->isVersioned(); | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?