Skip to content

Conversation

@statox
Copy link

@statox statox commented Jul 22, 2020

I think that when setting the colors for dark mode two unknown variables are used and they look like a typo. CSS really is not my strong suit so let me know if I'm wrong.

Amazing framework tho thank you for your work 👍

@vercel
Copy link

vercel bot commented Jul 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/x-z/new-css/1w8hg2441
✅ Preview: https://new-css-git-fork-statox-master.x-z.vercel.app

@statox
Copy link
Author

statox commented Sep 2, 2020

Hi @3x do you have a feedback on this PR? Please let me know if this is incomplete or if it needs additional changes to be accepted. Also note that a new PR is addressing the same typo.

@px-64
Copy link
Member

px-64 commented Sep 2, 2020

Hey @statox, I apologize for being inactive. These variables will be changed in v2.0 with more human-readable names. I'll leave this issue open for reference when 2.0 releases.

@statox statox mentioned this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants