Allow &[u8] and Vec<u8> input
#75
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library immediately converts
&strinput to&[u8]withas_bytes()and then does not appear to assume that the input is UTF-8 encoded, in the sense that non-UTF-8 input does not cause any undefined behavior, panics, or an invalid generated DOM. Since there is noparse()variant with&[u8]input, given such an input to parse, it is necessary to awkwardly use the unsafestr::from_utf8_uncheckedto avoid unnecessary UTF-8 check overhead.This pull request:
inputparameter ofParser::newfrom&strto&[u8],inputparameter ofVDomGuard::newfromStringtoVec<u8>(note that asStringis backed withVec<u8>, conversion from the former to the latter is cheap),VDomGuardfrom*mut strto*mut [u8],parse_bytes()andparse_bytes_owned()functions,Fixes #61.