Proposed resolution to the issue #114#122
Open
zulfequar wants to merge 3 commits intoyako-dev:masterfrom
Open
Conversation
added 3 commits
November 30, 2023 15:21
…ethod Modify the code so that animations are handled (controlled) everytime a badge widget's build method is called. * If the showBadge property of a badge is true: Run the animations * If the showBadge property of a badge is false: Stop the animations
…eld to false The commit cf980c9 fixes the intended issue for all types of animations (BadgeAnimation.slide, BadgeAnimation.scale, BadgeAnimation.rotate etc.) but once the showBadge field is set to true after setting it to false, the badge is shown back but its animation stops. Initializing the badge's appearanceDisappearanceFadeAnimationEnabled field to false fixes this issue. The code in this commit and in the commit cf980c9 has been tested on Android and Web and works fine on both the platforms and I expect that it should work fine on all the other platforms.
Update word from Yheme to Theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issue #114
Testing and Review Notes
I have tested the results on Android and Web. Please do all the required tests and reviews for the commits from your end before accepting it.
To Do
Please do all the required tests and reviews for the commits from your end before accepting.