Update CMakeLists.txt#203
Merged
yanyiwu merged 1 commit intoyanyiwu:masterfrom Jul 18, 2025
sheldonrobinson:master
Merged
Conversation
Add cppjieba library deefinition
There was a problem hiding this comment.
Pull Request Overview
This PR adds the cppjieba library definition to the CMake build system. The change creates an interface library target for cppjieba with appropriate include directories.
- Adds
cppjiebaas an INTERFACE library target - Configures include directories for the main project and limonp dependency
Comment on lines
+24
to
+28
| add_library(cppjieba INTERFACE) | ||
| target_include_directories(cppjieba INTERFACE | ||
| ${PROJECT_SOURCE_DIR}/include | ||
| ${PROJECT_SOURCE_DIR}/deps/limonp/include | ||
| ) |
There was a problem hiding this comment.
Consider checking if the cppjieba target already exists before creating it to avoid potential conflicts when this CMakeLists.txt is included multiple times. You can use if(NOT TARGET cppjieba) to guard the library creation.
Suggested change
| add_library(cppjieba INTERFACE) | |
| target_include_directories(cppjieba INTERFACE | |
| ${PROJECT_SOURCE_DIR}/include | |
| ${PROJECT_SOURCE_DIR}/deps/limonp/include | |
| ) | |
| if(NOT TARGET cppjieba) | |
| add_library(cppjieba INTERFACE) | |
| target_include_directories(cppjieba INTERFACE | |
| ${PROJECT_SOURCE_DIR}/include | |
| ${PROJECT_SOURCE_DIR}/deps/limonp/include | |
| ) | |
| endif() |
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cppjieba library definition