Add guard to cppjieba target#205
Merged
yanyiwu merged 1 commit intoyanyiwu:masterfrom Jul 18, 2025
sheldonrobinson:master
Merged
Add guard to cppjieba target#205yanyiwu merged 1 commit intoyanyiwu:masterfrom sheldonrobinson:master
yanyiwu merged 1 commit intoyanyiwu:masterfrom
sheldonrobinson:master
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a guard condition to prevent duplicate creation of the cppjieba target in CMake. The guard ensures that the target is only created once when the CMakeLists.txt file is included multiple times in a project.
Key changes:
- Added
if(NOT TARGET cppjieba)guard around the target creation - Prevents potential CMake configuration conflicts in multi-include scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about the late update.
Check if the cppjieba target already exists before creating it to avoid potential conflicts when this CMakeLists.txt is included multiple times.