New footprints #36
Open
New footprints #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, sorry that I responded after such a long while. I like your footprints. Could you rebase your changes on the current master (e.g., the template generator was migrated to PcbDraw itself)? I will be more than happy to merge these changes! |
Author
|
Hi Honza, thank you for your answer. Yes, I will prepare a rebase over the upstream version. I'll also check our new footprints/models since this PR. |
Author
|
Hi Honza, I have finally rebased this PR. Could you merge it please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yaqwsx,
I would like to add my footprints into upstream. Added footprints are used in MLAB modules. They are certainly not all footprints. I assume that I will create another PR.
Thanks
Roman