test(mcp): validate install_mcp OSError path exits with code 1#4
Draft
test(mcp): validate install_mcp OSError path exits with code 1#4
Conversation
Co-authored-by: ychampion <68075205+ychampion@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review code changes in pull request #3
test(mcp): validate install_mcp OSError path exits with code 1
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3 added a test for the
OSErrorhandling branch ininstall_mcp()but used a brittle string-suffix check to target the config file. Applied the PR with one improvement.Changes
tests/test_codeclaw_cli_mcp.pyimport pytest(required forpytest.raises)test_install_mcp_handles_read_oserror: monkeypatchesPath.read_textto raiseOSErrorfor the specific config path and assertsSystemExit(1)str(self).endswith("mcp.json")→self == config_pathto prevent false matches on unrelated files🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.