fix: Add safety check for b:ycm_hover#4298
Merged
puremourning merged 1 commit intoycm-core:masterfrom Dec 30, 2025
Merged
Conversation
Member
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
a641c99 to
79b7e54
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4298 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 37 37
Lines 4765 4765
=======================================
Hits 4279 4279
Misses 486 486 🚀 New features to boost your workflow:
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Prelude
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
The function s:ShowHoverResult() assumes b:ycm_hover always exists when processing hover responses. However, this assumption is unsafe, and leads to errors like this:
So I added a check for the existence of a variable.
This change is