Skip to content

Add feature to define LSP settings in g:ycm_language_server#1809

Merged
mergify[bot] merged 3 commits intoycm-core:masterfrom
Felixoid:ycm_language_server.settings
Jan 13, 2026
Merged

Add feature to define LSP settings in g:ycm_language_server#1809
mergify[bot] merged 3 commits intoycm-core:masterfrom
Felixoid:ycm_language_server.settings

Conversation

@Felixoid
Copy link
Contributor

@Felixoid Felixoid commented Jan 11, 2026

In ycm-core/YouCompleteMe#4272, I asked if it's possible to define global LSP settings in .vimrc

Here's the patch that adds this feature, so the settings option will be global with overrides from .ycm_extra_conf.py.


This change is Reviewable

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think this is OK and inline with how our built-in completes can set default config, so I'm happy with the general approach, just there's quite a big bug with the implementation doing a shallow copy and only allowing limited layering.

@Felixoid Felixoid requested a review from puremourning January 12, 2026 22:31
Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just a couple of nits actually.

@Felixoid Felixoid force-pushed the ycm_language_server.settings branch from 6beb205 to c816c9c Compare January 13, 2026 09:57
Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@puremourning reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @Felixoid).

@puremourning puremourning added the Ship It! Manual override to merge a PR by maintainer label Jan 13, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026

Thanks for sending a PR!

@mergify mergify bot added the queued label Jan 13, 2026
mergify bot added a commit that referenced this pull request Jan 13, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026

Merge Queue Status

✅ The pull request has been merged at c816c9c

This pull request spent 40 minutes 21 seconds in the queue, including 40 minutes 11 seconds running CI.
The checks were run on draft #1810.

Required conditions to merge
  • status-success=C++ Lint
  • status-success=macos-14 - C++ Benchmark
  • status-success=macos-14 - test run
  • status-success=ubuntu-24.04 - C++ Benchmark
  • status-success=ubuntu-24.04 - test run
  • status-success=ubuntu-24.04 - with Clang compiler - test run
  • status-success=ubuntu-24.04 - without libclang completer - test run

@mergify mergify bot merged commit 66cb021 into ycm-core:master Jan 13, 2026
10 of 11 checks passed
@mergify mergify bot removed the queued label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ship It! Manual override to merge a PR by maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants