Add feature to define LSP settings in g:ycm_language_server#1809
Add feature to define LSP settings in g:ycm_language_server#1809mergify[bot] merged 3 commits intoycm-core:masterfrom
Conversation
puremourning
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I think this is OK and inline with how our built-in completes can set default config, so I'm happy with the general approach, just there's quite a big bug with the implementation doing a shallow copy and only allowing limited layering.
puremourning
left a comment
There was a problem hiding this comment.
thanks! just a couple of nits actually.
6beb205 to
c816c9c
Compare
puremourning
left a comment
There was a problem hiding this comment.
@puremourning reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @Felixoid).
|
Thanks for sending a PR! |
Merge Queue Status✅ The pull request has been merged at c816c9c This pull request spent 40 minutes 21 seconds in the queue, including 40 minutes 11 seconds running CI. Required conditions to merge
|
In ycm-core/YouCompleteMe#4272, I asked if it's possible to define global LSP settings in
.vimrcHere's the patch that adds this feature, so the
settingsoption will be global with overrides from.ycm_extra_conf.py.This change is