Fix %-encoding in UriToFilePath#1815
Merged
puremourning merged 1 commit intoycm-core:masterfrom Mar 1, 2026
Merged
Conversation
Member
Author
|
hmm it does seem that the change was in Python 3.14: https://docs.python.org/3/library/urllib.request.html#urllib.request.url2pathname And require_scheme was only added in Python 3.14 so we can't merge this as is. |
In ycm-core#1119 a change was made to "unquote" the URI before converting to a file path, ostensibly to support windows. It seems that in Python 3.14 the underlying issue this was working around was fixed, and as a result we're broken, leading to paths being truncated. The tests added for UriToFilePath with Windows paths still pass unchanged without the hack on Python 3.14 and the new test passes on pre-3.14 with the hack, so we have to gate it on version, sadly.
puremourning
force-pushed
the
fix-uritofilepath
branch
from
0cd7681 to
5cbe038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1119 a change was made to "unquote" the URI before converting to a file path, ostensibly to support windows. It seems that either that change was broken, or that Python standard library has since been fixed and this has caused legitimate %-encoded paths (like foo#bar/test.c) to now truncate at the #.
The tests added for UriToFilePath with Windows paths still pass unchanged without the hack on Python 3.14 so I'm happy to just remove the hack.
Fixes #1814
This change is