Ensure disk registry state in blockstore-client private API#5263
Open
PeshkovMikhail wants to merge 1 commit intoydb-platform:mainfrom
Open
Ensure disk registry state in blockstore-client private API#5263PeshkovMikhail wants to merge 1 commit intoydb-platform:mainfrom
PeshkovMikhail wants to merge 1 commit intoydb-platform:mainfrom
Conversation
Contributor
|
Hi! Thank you for contributing! |
komarevtsev-d
added
blockstore
github-actions
bot
removed
the
ok-to-test
Contributor
komarevtsev-d
changed the title
| if (!google::protobuf::util::JsonStringToMessage(Input, &request->Record) | ||
| .ok()) | ||
| { | ||
| Error = MakeError(E_ARGUMENT, "Failed to parse input"); |
Collaborator
There was a problem hiding this comment.
эта ошибка где используется?
|
|
||
| TString output; | ||
| google::protobuf::util::MessageToJsonString(msg->Record, &output); | ||
| auto response = std::make_unique<TEvService::TEvExecuteActionResponse>(); |
Collaborator
There was a problem hiding this comment.
если пришла ошибка, то правильно её в ответ и завернуть
| for agent_id in agent_ids: | ||
| p = _get_agent_data_path(agent_id, data_path) | ||
| with open(os.path.join(p, 'NVMENBS01'), 'wb') as f: | ||
| os.truncate(f.fileno(), DEVICES_PER_PATH * (DEVICE_SIZE + 4096)) |
Collaborator
There was a problem hiding this comment.
fallocate сейчас везде в тестах
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4873
Added service with
ensurediskregistrystateintegrity. In case the disk registry states from memory and local db are different, the mismatches between them is returned.