[Disk Manager] Refactor Filestore client logs#5330
Conversation
|
Copypasted config from mr #3139 so the commit message is kind strange. Will be changed during squash |
There was a problem hiding this comment.
Pull request overview
This PR refactors logging in the Filestore Go public SDK client by replacing the previous context-aware Log/Logger(level) design with a single Logger interface exposing level-specific *f methods, and updates Disk Manager’s NFS client wiring accordingly.
Changes:
- Replaced
Log/per-level logger selection with a unifiedLoggerinterface (addsLOG_TRACE, removes syslog support). - Updated Filestore SDK clients (grpc + durable) and constructors to accept/use the new
Logger. - Updated Disk Manager NFS client factory/endpoint health-check to pass the Disk Manager logger directly; removed the custom wrapper logger types.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| cloud/filestore/public/sdk/go/client/ya.make | Removes log_test.go from test sources. |
| cloud/filestore/public/sdk/go/client/log_test.go | Deletes tests for the previous logging API. |
| cloud/filestore/public/sdk/go/client/log.go | Introduces new Logger interface + default logger implementation; adds LOG_TRACE. |
| cloud/filestore/public/sdk/go/client/grpc.go | Switches request logging to the new Logger calls; updates ctor signature. |
| cloud/filestore/public/sdk/go/client/durable.go | Switches retry logging to the new Logger calls; updates ctor signatures. |
| cloud/filestore/public/sdk/go/client/client.go | Updates top-level SDK constructors to accept a Logger. |
| cloud/filestore/public/sdk/go/client/durable_test.go | Adjusts tests to pass the new Logger parameter name/type. |
| cloud/disk_manager/internal/pkg/clients/nfs/factory.go | Removes custom log wrapper and passes logging.GetLogger(ctx) to the SDK. |
| cloud/disk_manager/internal/pkg/clients/nfs/endpoint_picker.go | Passes logging.GetLogger(ctx) to the SDK for health checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 366s): all tests PASSED for commit 59d0d29.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 1855s): all tests PASSED for commit 59d0d29.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7052s): all tests PASSED for commit 59d0d29.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11282s): all tests PASSED for commit 59d0d29.
|
No description provided.