Skip to content

[Disk Manager] Refactor Filestore client logs#5330

Open
jkuradobery wants to merge 1 commit intomainfrom
users/jkuradobery/fix-nfs-client-logging
Open

[Disk Manager] Refactor Filestore client logs#5330
jkuradobery wants to merge 1 commit intomainfrom
users/jkuradobery/fix-nfs-client-logging

Conversation

@jkuradobery
Copy link
Collaborator

No description provided.

[Disk Manager] Refactor Filestore client logs
@jkuradobery
Copy link
Collaborator Author

Copypasted config from mr #3139 so the commit message is kind strange. Will be changed during squash

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors logging in the Filestore Go public SDK client by replacing the previous context-aware Log/Logger(level) design with a single Logger interface exposing level-specific *f methods, and updates Disk Manager’s NFS client wiring accordingly.

Changes:

  • Replaced Log/per-level logger selection with a unified Logger interface (adds LOG_TRACE, removes syslog support).
  • Updated Filestore SDK clients (grpc + durable) and constructors to accept/use the new Logger.
  • Updated Disk Manager NFS client factory/endpoint health-check to pass the Disk Manager logger directly; removed the custom wrapper logger types.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
cloud/filestore/public/sdk/go/client/ya.make Removes log_test.go from test sources.
cloud/filestore/public/sdk/go/client/log_test.go Deletes tests for the previous logging API.
cloud/filestore/public/sdk/go/client/log.go Introduces new Logger interface + default logger implementation; adds LOG_TRACE.
cloud/filestore/public/sdk/go/client/grpc.go Switches request logging to the new Logger calls; updates ctor signature.
cloud/filestore/public/sdk/go/client/durable.go Switches retry logging to the new Logger calls; updates ctor signatures.
cloud/filestore/public/sdk/go/client/client.go Updates top-level SDK constructors to accept a Logger.
cloud/filestore/public/sdk/go/client/durable_test.go Adjusts tests to pass the new Logger parameter name/type.
cloud/disk_manager/internal/pkg/clients/nfs/factory.go Removes custom log wrapper and passes logging.GetLogger(ctx) to the SDK.
cloud/disk_manager/internal/pkg/clients/nfs/endpoint_picker.go Passes logging.GetLogger(ctx) to the SDK for health checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 366s): all tests PASSED for commit 59d0d29.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
863 863 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 1855s): all tests PASSED for commit 59d0d29.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1322 1322 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7052s): all tests PASSED for commit 59d0d29.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3441 3441 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11282s): all tests PASSED for commit 59d0d29.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
6286 6285 0 0 0 1 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-tests Launch large tests for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants