test #67
Open
test #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesjin-git
reviewed
Dec 29, 2019
Owner
yesjin-git
left a comment
yesjin-git
left a comment
There was a problem hiding this comment.
고생하셨습니다! 요구사항에 맞게 잘 개발해주셨습니다. A-드립니다.
컴포넌트 재사용 측면에서 1을 더하는 컴포넌트와 2를 더하는 컴포넌트를 따로 만들지 않고 props로 interval값만 넘겨줘서 작성할 수 있습니다. 자세한 내용은 답안지를 확인해 주세요.
추가적으로 커맨트 드린바와 같이 component will unmount에 clock을 멈추는 함수를 실행시킬 수 있도록 해야된다는 점 잘 기억해주세요.
| this.setState({ date: new Date() }); | ||
| }, 1000); | ||
| } | ||
| handleDecrease() { |
Owner
There was a problem hiding this comment.
stop clock 같은 매소드 명이 더 좋을 것 같습니다.
| } | ||
| handleDecrease() { | ||
| this.intervalId = clearInterval(() => { | ||
| this.setState({ date: Date() }); |
Owner
There was a problem hiding this comment.
clear interval 은 component will unmount 에서도 꼭 콜되어야 합니다.
https://reactjs.org/docs/state-and-lifecycle.html 이 부분을 참고해 주세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.