2week #73
Open
2week #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesjin-git
reviewed
Dec 29, 2019
Owner
yesjin-git
left a comment
yesjin-git
left a comment
There was a problem hiding this comment.
B+ 드립니다.
잘 시도해주셨습니다. 지난 시간에 배우신 내용들은 잘 숙지하고 계신 것 같습니다.
커맨트 드린바와 같이 삼항연산자와 &&, || 를 사용해보시면 더욱 좋을 것 같습니다.
https://reactjs.org/docs/conditional-rendering.html
| {id: 2, title: "title3", content: "default3"} | ||
| {id: 0, title: "title1", content: "default1", isFocused: false}, | ||
| {id: 1, title: "title2", content: "default2", isFocused: false}, | ||
| {id: 2, title: "title3", content: "default3", isFocused: false} |
Owner
There was a problem hiding this comment.
isFocused는 note 내부에 state로 관리하는 편이 더 깔끔할 것 같습니다. app에서 isFocused를 알고 있지 않아도 되기 때문입니다. 답안을 참고해주세요.
| {this.state.savedNotes.map((note, index) => ( | ||
| <Note | ||
| delete={this.delete} | ||
| edit={this.isFocused} |
Owner
There was a problem hiding this comment.
코드 작성중에 끊기셔서 이런 부분이 나온 것 같습니다.
| this.setState({ | ||
| isEditFocused: false | ||
| }) | ||
| console.log(this.props.index + "is not focused") |
Owner
There was a problem hiding this comment.
처음에는 이렇게 리뷰를 달면서 작업하는게 좋습니다. 잘하셨습니다.
| render() { | ||
| const {title, content} = this.props | ||
| const editFocus = this.state.isEditFocused | ||
| if (!editFocus) { |
Owner
There was a problem hiding this comment.
이 부분은 삼항연산자를 활용하는 것을 연습해보시면 더 좋을 것 같습니다.
마찬가지로 && 와 || 도 활용해보세요.(답안을 참고하시면 사용 예제가 있습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
도저히 모르겠어서 일단 제출합니다 ㅠ_ㅠ