4week HW #77
Open
4week HW #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- redux 적용과제 - delete 버튼 추가.
dopa1213
reviewed
Jan 15, 2020
| function todoApp(state = initState, action) { | ||
| switch (action.type) { | ||
| case ADD_TODO: | ||
| let newNo = (state.todos.length === 0) ? 1 : state.todos[state.todos.length - 1].no + 1 |
There was a problem hiding this comment.
직접 유니크한 값을 생성해 주는건 너무 좋은 판단이셨습니다!
다만 리듀서는 값을 생성해주는 곳이 아니라 전달 받은 데이터로 새로운 state를 만들어 주는곳입니다.
그래서 no값은 addTodo액션을 실행하는 컴포넌트에서 생성해서 액션으로 함께 넘겨주시는 것이 좋습니다.
dopa1213
reviewed
Jan 15, 2020
| } | ||
|
|
||
| handleSubmit = e => { | ||
| const text = this.state.text |
There was a problem hiding this comment.
객체구조 분해 할당을 이용해서 좀더 깔끔하게 원하는 값을 가져 오실수 있습니다!
ex) const { text } = this.state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. /note-hw 에 구현하였습니다.