Merge main (v2.0.2) into develop #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which includes change that supports facetAllowlist query parameter for vertical searches
* drop node 16 from github workflows We are dropping node 16 support, and have removed it from the related slapshot reusable workflows already. This PR drops it from the github workflows for this repo J=none TEST=none * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* v1.10.1 (#565) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: upgrade playwright version to avoid vuln This PR ups the playwright version used to avoid a vuln J=VULN-40423 TEST=compile * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * remove version upgrade workflow * remove version change * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
J=WAT-5112 TEST=manual --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Fix originally made in #576 by @chrissnyder2337 When collapsible={false}, FilterGroup now renders a plain div instead of CollapsibleSection, preventing orphaned aria-labelledby references that point to non-existent toggle button IDs. This fix improves WCAG 2.1 accessibility compliance (1.3.1 Info and Relationships; 4.1.2 Name, Role, Value) by ensuring screen readers only encounter properly labeled regions. --------- Co-authored-by: Claude <noreply@anthropic.com> * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: Chris Snyder <chris@chrissnyder.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
#584) * update search bar components to improve accessibility * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update tests * Update snapshots * Update snapshots * Update snapshots * add required aria attributes to pass WCAG * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update storybook styling for dropdown items * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* update generate license config * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * try using test branch of workflow * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * fix typo * Update snapshots * add generate_license_version param to yml * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * Update snapshots * Update snapshots * update text in jsonlint-lines-primitives override * Update snapshots * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * remove extra dashed line * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * point to v1 workflow branch after update in that repo * Update snapshots * Update snapshots * capitalization typo from prev PR * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…pt (v1.11.0) (#589) * upgrade to React 19; add backwards compatibility test-site script * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * try updating run-tests.yml * codex: try fixing old react errors * update storybook command from p -> port * update types and fiddle with Mapbox pin code to pass storybook tests * wrap various tasts with act() to cut down on log warns * try to update storybook config to get tests to pass * Update snapshots * Update snapshots * Update snapshots * Update snapshots * rerun npm i in test site * slight code cleanup * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * nits * Update snapshots * Update snapshots * update kill command in visual coverage * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* add logic to only fit bounds when padding fits in canvas
A vulnerability exists in storybook 8.5.0 that bundles the .env file in the static output during the storybook build. This vulnerability is fixed in version 8.6.15. J=VULN-40848 TEST=auto --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* support autocomplete limits * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Layers that don't have name properties do not need to be localized (e.g. highway numbers). Localizing them was overriding their properties, which caused them to not show up on the map. J= WAT-5275 TEST=manual verified on test-site that road shields and route markers now show up, and place names are still localized as expected. * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * add parenthesis to make conditions clearer * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* try awaiting to reduce update snapshot flakiness * additional update to static filters since that caused some snapshot failures too * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
J=WAT-5279 TEST=manual,auto tested on test-site added new test case to SearchBar.test.tsx and ran npm run test
* ksearch: upgrade to Events API This PR upgrades our analytics calls to the next major version, also called the Events API. As part of this work, analytics calls have changed shape, and some deprecated properties have been dropped. J=WAT-4651 TEST=auto,manual Updated auto tests. Ran test site locally and saw events all the way to snowflake. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* add linter; update all files with correct linting * add husky config for pre-commit validation * rerun npm i in test site * Update snapshots * Update snapshots * Update snapshots * fix dropdown item widths; don't scroll through dropdown items on tab * Update snapshots * fix test for dropdown tab behavior change * update storybook test to not use tab to cycle through dropdown * Update snapshots * minor style nit --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This was apparently causing more Invalid LngLat issues in iframes. Now, the map should be correctly sized and taking into account it's actual viewport size. The map's actual viewport is the canvas client size. canvas.width/height represents the device pixels, which is often larger than the CSS size. canvas.clientWidth/clientHeight uses the CSS pixel size, which is also what fitBounds uses, which is likely why we were running into issues before. J=WAT-5303 TEST=manual Packed tarball and saw a test VE site no longer run into the error
Contributor
Author
|
Current unit coverage is 89.77272727272727% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main (v2.0.2) into develop