-
Notifications
You must be signed in to change notification settings - Fork 0
fix: prop label and format in hour atom, german translations #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| Key | Languages Removed |
|---|---|
fields.alignCard |
cs,da de,en en-GB,es et,fi fr,hr hu,it ja,lt lv,nb nl,pl pt,ro sk,sv tr,zh zh-TW |
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
WalkthroughThis PR updates localization keys and strings in the visual-editor package. The key Sequence Diagram(s)(Section intentionally omitted.) Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packages/visual-editor/locales/components/de/visual-editor.json`:
- Line 14: The translation values for the time labels include a literal "xx:xx"
placeholder; remove the placeholder so the keys only contain the introductory
text. Update the JSON entries for "closesAt" and "opensAt" to drop "xx:xx" (and
any literal "Uhr" time) so they become simple phrases like "schließt um" and
"öffnet um" respectively, matching how the component renders the actual time in
a separate span.
In `@packages/visual-editor/locales/platform/de/visual-editor.json`:
- Line 68: Replace the literal "xx:xx" placeholders in the locale entries
"closesAt" and "opensAt" with an interpolation token (e.g., "{{time}}") so the
strings become dynamic; update the values for the keys "closesAt" and "opensAt"
in visual-editor.json to use "{{time}}" (matching the components locale usage)
and ensure any code that calls these keys passes the formatted time string into
the translation interpolation.
packages/visual-editor/locales/components/de/visual-editor.json
Outdated
Show resolved
Hide resolved
|
You can revert the opensAt/closesAt translations, @mkilpatrick will handle that since the hours need to be interpolated in the translation. Otherwise LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This locale is missing contentAlignment for some reason
Tickets OPAQF-91, OPAQF-87
Updated Translations in German.
In Hours Atom