Skip to content

Conversation

@rkeerthient
Copy link
Contributor

Tickets OPAQF-91, OPAQF-87

Updated Translations in German.

In Hours Atom

  • Updated Show hours text case
  • Renamed Align card to Content Alignment
  • Updated Locales Accordingly.
Screenshot 2026-01-20 at 11 46 57 PM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

⚠️ Deleted Translation Keys Detected

🔤 Deleted Translation Keys

fields

Key Languages Removed
fields.alignCard cs,da de,en en-GB,es et,fi fr,hr hu,it ja,lt lv,nb nl,pl pt,ro sk,sv tr,zh zh-TW

@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

Walkthrough

This PR updates localization keys and strings in the visual-editor package. The key fields.alignCard is removed and replaced by fields.contentAlignment across many platform locale files; corresponding translations were added. In German locales, three location-related strings (findALocation, getDirections, visitPage) were changed. The HoursTable component was updated to use fields.contentAlignment and the label showAdditionalHoursText capitalization was standardized.

Sequence Diagram(s)

(Section intentionally omitted.)

Possibly related PRs

Suggested labels

create-dev-release

Suggested reviewers

  • benlife5
  • mkilpatrick
  • asanehisa
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately summarizes the main changes: fixing prop labels/formats in the hours atom and updating German translations, which is the primary focus of the changeset.
Description check ✅ Passed The PR description is clearly related to the changeset, referencing the specific tickets and detailing the updates to German translations and the Hours Atom changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@packages/visual-editor/locales/components/de/visual-editor.json`:
- Line 14: The translation values for the time labels include a literal "xx:xx"
placeholder; remove the placeholder so the keys only contain the introductory
text. Update the JSON entries for "closesAt" and "opensAt" to drop "xx:xx" (and
any literal "Uhr" time) so they become simple phrases like "schließt um" and
"öffnet um" respectively, matching how the component renders the actual time in
a separate span.

In `@packages/visual-editor/locales/platform/de/visual-editor.json`:
- Line 68: Replace the literal "xx:xx" placeholders in the locale entries
"closesAt" and "opensAt" with an interpolation token (e.g., "{{time}}") so the
strings become dynamic; update the values for the keys "closesAt" and "opensAt"
in visual-editor.json to use "{{time}}" (matching the components locale usage)
and ensure any code that calls these keys passes the formatted time string into
the translation interpolation.

@benlife5
Copy link
Contributor

You can revert the opensAt/closesAt translations, @mkilpatrick will handle that since the hours need to be interpolated in the translation. Otherwise LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This locale is missing contentAlignment for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants