More info list buffers #1084
Open
More info list buffers #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The main issue this seems to be addressing is present in both the emacs and vim keymaps: but your PR only seems to fix it in the emacs keymap. Maybe in the weekend I'll have a look and see if I can address that. |
Author
|
I haven't studied how the |
For now is just a read-only flag and the current buffer flag.
Fow now we put the BufferRef on the *Buffer List* althought this can be confusing for users. The alternative is to extend the ADT to hold some state per mode or the use of invisible buffers a lá Emacs.
This command changes the behaviour of the old 'KEnter' event as it doesn't set ReadOnly = False when switching. This flag set/unsets with the same command. Also documented most of the new functions on this module.
RubenAstudillo
force-pushed
the
more-info-list-buffers
branch
from
31c110b to
b5cd442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes the
Buffer Listmode more Emacs like. Now there is only a singleBuffer Listinstance, we can flag files for Deletetion and eXecution, set readonly status and unset flags via the usual keys from emacs.On a technical side, I had to change the function to work on
BufferRefinstead ofBufferIdotherwise when eXecuting buffer, if two shared the same infix name (as is common with dired buffers) it would kill them all. As no extra state can be had on a mode, I had to put theBufferRefon theBufferListon the second column. It is hack-ish but works, plus I didn't have to deal with invisible buffers as in Emacs.