feat: Secret references in NGINX Ingress controller annotations support#564
Draft
dabico wants to merge 2 commits intoyonahd:mainfrom
Draft
feat: Secret references in NGINX Ingress controller annotations support#564dabico wants to merge 2 commits intoyonahd:mainfrom
dabico wants to merge 2 commits intoyonahd:mainfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
- Coverage 45.74% 45.69% -0.06%
==========================================
Files 69 69
Lines 3941 3950 +9
==========================================
+ Hits 1803 1805 +2
- Misses 1838 1844 +6
- Partials 300 301 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Take values of specific
nginx.ingress.kubernetes.ioannotations into consideration when performing scans ofSecretresources referenced inIngress.PR Checklist
GitHub Issue
Closes #560
Notes for your reviewers
The current approach has a limitation: it only takes into account secret references within the same namespace. The NGINX ingress controller annotations can actually reference secrets from other namespaces. Not sure how to implement this cleanly cleanly in the current approach, while taking flags like
--exclude-namespaceinto consideration.