Skip to content

Disable resource grouping flag for exporter subcommand#565

Open
dabico wants to merge 1 commit intoyonahd:mainfrom
dabico:exporter
Open

Disable resource grouping flag for exporter subcommand#565
dabico wants to merge 1 commit intoyonahd:mainfrom
dabico:exporter

Conversation

@dabico
Copy link
Contributor

@dabico dabico commented Feb 7, 2026

What this PR does / why we need it?

Makes changes to flag definitions withing both the root command and all subcommands in such a way that everything except exporter will be able to specify --group-by.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

Closes #555

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.18%. Comparing base (58fc28d) to head (c52f522).

Files with missing lines Patch % Lines
cmd/kor/root.go 0.00% 7 Missing ⚠️
cmd/kor/all.go 0.00% 2 Missing ⚠️
cmd/kor/exporter.go 0.00% 2 Missing ⚠️
cmd/kor/clusterrolebindings.go 0.00% 1 Missing ⚠️
cmd/kor/clusterroles.go 0.00% 1 Missing ⚠️
cmd/kor/configmaps.go 0.00% 1 Missing ⚠️
cmd/kor/crds.go 0.00% 1 Missing ⚠️
cmd/kor/daemonsets.go 0.00% 1 Missing ⚠️
cmd/kor/deployments.go 0.00% 1 Missing ⚠️
cmd/kor/finalizers.go 0.00% 1 Missing ⚠️
... and 18 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   46.56%   46.18%   -0.38%     
==========================================
  Files          69       69              
  Lines        3930     3962      +32     
==========================================
  Hits         1830     1830              
- Misses       1794     1826      +32     
  Partials      306      306              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics have kind and namespace label values swapped when --group-by=resource is specified

2 participants