Skip to content

fix: Do not use latest for image, instead use the appVersion defined … #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bseenu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Do not use latest for image, instead use the appVersion defined … #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/kor/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
securityContext:
{{ toYaml . | nindent 12 }}
{{- end }}
image: "{{ .Values.prometheusExporter.deployment.image.repository }}:{{ .Values.prometheusExporter.deployment.image.tag }}"
image: "{{ .Values.prometheusExporter.deployment.image.repository }}:{{ .Values.prometheusExporter.deployment.image.tag | default (printf "v%s" .Chart.AppVersion) }}"
command:
{{- toYaml .Values.prometheusExporter.command | nindent 12 }}
args:
Expand Down
2 changes: 1 addition & 1 deletion charts/kor/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ prometheusExporter:
deployment:
image:
repository: yonahdissen/kor
tag: latest
# tag: latest, default is appVersion read from Chart.yaml
restartPolicy: Always
imagePullPolicy: Always
imagePullSecrets: []
Expand Down