-
Notifications
You must be signed in to change notification settings - Fork 0
chore(ci): Disable NPM tokens in release workflow #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Comment out NODE_AUTH_TOKEN and NPM_TOKEN for security during migration to NPM OIDC-based publishing authentication Signed-off-by: Jeff Hampton <jhampton@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Greptile SummaryThis PR disables NPM token-based authentication in the release workflow by commenting out Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GitHub as GitHub Actions
participant Checkout as Checkout Code
participant NodeSetup as Setup Node/NPM
participant Validate as Validate
participant Release as semantic-release
participant NPM as NPM Registry
participant OIDC as GitHub OIDC Provider
GitHub->>Checkout: Fetch repository (SSH key)
GitHub->>NodeSetup: Configure npm registry
NodeSetup->>NodeSetup: Configure registry-url
GitHub->>Validate: Run typecheck/lint/test/build
Validate-->>GitHub: All checks pass
GitHub->>Release: Run semantic-release
Release->>Release: Check version, generate changelog
Release->>NPM: Request OIDC token from GitHub
Release->>OIDC: Get short-lived OIDC token
OIDC-->>Release: Return token (id-token permission)
Release->>NPM: Publish package with OIDC token
NPM-->>Release: Package published
Release->>GitHub: Create release and git tags
Release-->>GitHub: Complete
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
## 0.8.0 (2026-01-16) * chore: Depend on most recent Swift SDK version and update breaking changes (#27) ([a042211](a042211)), closes [#27](#27) * chore(ci): Disable NPM tokens in release workflow (#28) ([c63c21a](c63c21a)), closes [#28](#28) * chore(ci): update semantic-release to support OIDC workflow (#29) ([de337dc](de337dc)), closes [#29](#29) * chore(ci): YPE-1050 Modify release.yml for permissions and Node.js version ([2c86c6f](2c86c6f)) * Add NODE_AUTH_TOKEN to release workflow ([2bdc89c](2bdc89c)) * Add provenance option to npm release configuration ([d746acf](d746acf)) * Enable NPM_CONFIG_PROVENANCE in release workflow ([e027853](e027853)) * Update Node.js version and add NPM upgrade step ([ee94aa2](ee94aa2)) * feat: add support for `configure` in Kotlin (#16) ([d9bca2d](d9bca2d)), closes [#16](#16) * feat: implement `setApiHost` and `getAccessToken` in Kotlin (#17) ([a4ee43c](a4ee43c)), closes [#17](#17) * feat: Implement `SignInWithYouVersionButton` for Kotlin (#26) ([5072471](5072471)), closes [#26](#26) * feat: Implement API utils for Kotlin/Android (#25) ([9a88926](9a88926)), closes [#25](#25) * feat: implement votd API endpoint for Kotlin (#19) ([59e6874](59e6874)), closes [#19](#19) * docs: add AI agent code review guidelines (#23) ([8218cec](8218cec)), closes [#23](#23)
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Comment out NODE_AUTH_TOKEN and NPM_TOKEN for security during migration to NPM OIDC-based publishing authentication
Description
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Breaking Changes
Breaking Change Details:
Migration Guide:
Checklist
Conventional Commits
✅ All commits in this PR follow conventional commit format:
Example commit messages:
feat(api): add Bible verse lookup methodfix(auth): resolve token refresh race conditiondocs: update installation instructionsFor breaking changes:
feat(api)!: redesign Bible content APISee CONTRIBUTING.md for detailed guidelines.
Related Issues
Closes #
Relates to #
Additional Context
Reviewer Notes