Optimize TranscriptionWorkerClient to use Transferables#105
Closed
ysdede wants to merge 1 commit intoaudit/perf-degradation-resource-mgmtfrom
Closed
Optimize TranscriptionWorkerClient to use Transferables#105ysdede wants to merge 1 commit intoaudit/perf-degradation-resource-mgmtfrom
ysdede wants to merge 1 commit intoaudit/perf-degradation-resource-mgmtfrom
Conversation
- Updated `TranscriptionWorkerClient.ts` to support transferring `ArrayBuffer` ownership in `sendRequest`. - Modified `processChunk`, `processV3Chunk`, `processV3ChunkWithFeatures`, `transcribeSegment`, and `processV4ChunkWithFeatures` to transfer audio and feature buffers instead of copying them. - This reduces main thread blocking during high-frequency worker communication, addressing performance issues noted in `issue-4-worker-message-overhead.md`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
4 tasks
Owner
Author
|
Superseded by PR #141 which implements a broader zero-copy transfer protocol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses performance issues related to main thread overhead when communicating with the Transcription Worker. By using Transferable objects for large audio and feature buffers, we eliminate the structured cloning cost, significantly reducing the time spent in
HandlePostMessageon the main thread. This ensures smoother UI performance during active transcription.PR created automatically by Jules for task 9617886535104194940 started by @ysdede