fix: add 5s timeout to TenVADWorkerClient requests#139
Open
ysdede wants to merge 1 commit intoaudit/perf-degradation-resource-mgmtfrom
Open
fix: add 5s timeout to TenVADWorkerClient requests#139ysdede wants to merge 1 commit intoaudit/perf-degradation-resource-mgmtfrom
ysdede wants to merge 1 commit intoaudit/perf-degradation-resource-mgmtfrom
Conversation
Prevents indefinite hanging when the worker fails to respond or initialize. Fixes `TenVADWorkerClient.test.ts` timeout failure. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
The PR adds a 5-second timeout mechanism to handle worker unresponsiveness or init failures. The implementation is sound. Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a 5-second timeout in
TenVADWorkerClient.sendRequest. This ensures that if the TEN-VAD worker fails to initialize (e.g., due to network error loading WASM) or crashes without sending a response, the client promise will reject with a timeout error instead of hanging indefinitely. This fixes theTenVADWorkerClient.test.tsfailure where the test timed out waiting for an error response that was lost or delayed.PR created automatically by Jules for task 14434834885389086806 started by @ysdede