fix: exclude URL(http/https/ftp) patterns from markdown-it-include target#351
Open
fukusuket wants to merge 1 commit intoyzane:masterfrom
Open
fix: exclude URL(http/https/ftp) patterns from markdown-it-include target#351fukusuket wants to merge 1 commit intoyzane:masterfrom
markdown-it-include target#351fukusuket wants to merge 1 commit intoyzane:masterfrom
Conversation
Author
Test (issue #181)Environment
before fixI have confirmed that the reproduction of the problem before fixing it as follows. after fixI have confirmed that there are no errors when exporting pdf and html as follows. |
Author
markdown-it-include targetmarkdown-it-include target
|
@yzane !! |
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Hello, Thank you so much for great tool :)
The issue #181 also occurred in my environment(win10/macOS/
vscode-markdown-pdf 1.5.0), so I fixed it.What Changed
Changed the regular expression targeted by
markdown-it-includeAbout the changed regular expression in this PR
before fix
All cases containing URL link patterns are targets of

markdown-it-includeas follows:after fix
URL link patterns are not targets of

markdown-it-includeas follows: (By using a negative lookahead regular expression)I would appreciate it if you could review.
Thanks again maintaining great tool !