Skip to content

Fix rendering Mermaid diagrams to PDFs and images#365

Open
haensen wants to merge 4 commits intoyzane:masterfrom
haensen:master
Open

Fix rendering Mermaid diagrams to PDFs and images#365
haensen wants to merge 4 commits intoyzane:masterfrom
haensen:master

Conversation

@haensen
Copy link

@haensen haensen commented May 2, 2024

Fixes issues #312, #318, #337 and #342.
Also, enables using Mermaid's newest features like xychart-beta with this tool.

The root cause of the problem was that sometime after and around version 10.5 Mermaid started using features that were unsupported by the Chromium version that this tool used. At least structuredClone-function was one such feature. So this fix pumps the Puppeteer from version 2.21 to 22.7.1, which pumps Chromium from version 80 to 124.

Also, the line that removes Chromium from the package is removed, because after Puppeteer v19 Chromium is stored to ~/.cache, which doesn't affect the package size.

@haensen haensen changed the title Fix rendering Mermaid diagrams to PDFs and images Work in Progress: Fix rendering Mermaid diagrams to PDFs and images May 2, 2024
@haensen haensen changed the title Work in Progress: Fix rendering Mermaid diagrams to PDFs and images Fix rendering Mermaid diagrams to PDFs and images May 3, 2024
@bqstony
Copy link

bqstony commented Nov 11, 2024

Please merge, would be nice mermaid would work again.

@ricardo-dlc
Copy link

Seems that the repo has been inactive for some time. I recently installed and wanted to use mermaid features, but noticed they were not displayed. Any other alternative? Merging this will be awesome.

@jorgeLandTO
Copy link

Still wanting a merge on this if possible. Any updates on the state of this PR?

@formeo14
Copy link

formeo14 commented Mar 24, 2025

@yzane When will it get merged? Or is this whole project dead? And this is the continuation (https://github.com/showzs/vscode-markdown-pdf)?

@haensen
Copy link
Author

haensen commented Mar 31, 2025

Here's the plugin file for this PR if somebody wants to install.
VSIX Release

@athompson-merlin
Copy link

@yzane When will it get merged? Or is this whole project dead? And this is the continuation (https://github.com/showzs/vscode-markdown-pdf)?

I'm going to guess "no" since (a) it's 17 commits behind the original project, and (b) hasn't been updated since 2023.
Many thanks to @haensen for providing an updated VSIX file that resolves the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants