Conversation
cdconn00
requested changes
Feb 20, 2026
Contributor
cdconn00
left a comment
cdconn00
left a comment
There was a problem hiding this comment.
review done see requested changes
|
|
||
| router.post("/login", oAuth, async (req, res) => { | ||
| try { | ||
| const { access_token } = req.oauth; |
Contributor
There was a problem hiding this comment.
@HDProduction010 there's still a lot of commented code out, make sure that the only changes are your updates and the testing changes are reverted
scripts/upsert,js
Outdated
| @@ -0,0 +1,44 @@ | |||
| import dotenv from "dotenv"; | |||
seeds/roles.json
Outdated
| { | ||
| "name": "Combined Monitor", | ||
| "code": "cm", | ||
| "order": 10, |
Contributor
There was a problem hiding this comment.
this should be 9 instead of 10, dont worry about updating it locally.
| sort: {order: 'asc'} | ||
| } | ||
| })*/ | ||
| path: 'roles', |
Contributor
There was a problem hiding this comment.
Can we just remove this commented out stuff?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.