Splitting the grid and the rest#18
Open
jdcrecur wants to merge 2 commits intozachacole:masterfrom
jdcrecur:master
Open
Splitting the grid and the rest#18jdcrecur wants to merge 2 commits intozachacole:masterfrom jdcrecur:master
jdcrecur wants to merge 2 commits intozachacole:masterfrom
jdcrecur:master
Conversation
- Broke out the actual grid sass from the rest.
- .row [class^="col"] meant you had to place the col-X before any other class on the element, considering the already super small size of this grid, explicitly declaring the row col-X makes this grid more flexible. - phpstorm has automatically styled some of the spacing, hope this is not an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Liked the simple grid, but didn't want to include the rest of the bits as this was to be dropped into an existing project. With this split, i can now just include the grid into my project and not have to worry about the rest.