Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Refactor type processing to use BFS traversal in Java codegen

Replaced the iteration over all type graph nodes with a Breadth-First Search (BFS) traversal starting from the root type. This ensures that the root struct is generated first in the output file and that only reachable types are processed.

  • Modified codegen-java/src/lib.rs:
    • Imported VecDeque and HashSet.
    • Implemented BFS loop with cycle detection.
    • Updated logic to traverse into children of Object, Union, Array, and Optional types.
    • Preserved root type name determination logic.

PR created automatically by Jules for task 12599796746808077555 started by @zahash

Replaced the iteration over all type graph nodes with a Breadth-First Search (BFS) traversal starting from the root type. This ensures that the root struct is generated first in the output file and that only reachable types are processed.

*   Modified `codegen-java/src/lib.rs`:
    *   Imported `VecDeque` and `HashSet`.
    *   Implemented BFS loop with cycle detection.
    *   Updated logic to traverse into children of Object, Union, Array, and Optional types.
    *   Preserved root type name determination logic.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Replaced the iteration over all type graph nodes with a Breadth-First Search (BFS) traversal starting from the root type. This ensures that the root struct is generated first in the output file and that only reachable types are processed.

*   Modified `codegen-java/src/lib.rs`:
    *   Imported `VecDeque` and `BTreeSet`.
    *   Implemented BFS loop with cycle detection using `BTreeSet` to avoid hash dependency.
    *   Updated logic to traverse into children of Object, Union, Array, and Optional types.
    *   Preserved root type name determination logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants