Skip to content

Added --db-filter and --user-filter flags#72

Open
kmoppel wants to merge 2 commits intomasterfrom
db_and_user_filtering
Open

Added --db-filter and --user-filter flags#72
kmoppel wants to merge 2 commits intomasterfrom
db_and_user_filtering

Conversation

@kmoppel
Copy link
Collaborator

@kmoppel kmoppel commented Feb 13, 2017

Flags for displaying processes on only desired DBs or users. Input should be Postgres regexes.

Flags for displaying processes on only desired DBs or users. Input should be Postgres regexes.
@kmoppel
Copy link
Collaborator Author

kmoppel commented Feb 13, 2017

Useful for test instances with lots of DBs for example. Pretty straightforward patch, security (relying on psycopg2 parameter parsing) shouldn't also be a problem as user anyways has access to the DB for normal queries.

@slitsche
Copy link
Member

Hey Kaarel,
Travis CI build failed. Could you please have a look at it?

@kmoppel
Copy link
Collaborator Author

kmoppel commented Feb 13, 2017

Hey Stefan! Ah yes, the linter. Hmm, but seems the failing code lines are actually the old one. And after running "autopep8 -i pg_view.py" I got around 30 other formatting changes..so not sure if I should commit it? Maybe I'm using the wrong tool?

pg_view.py:146:1: E305 expected 2 blank lines after class or function definition, found 1
pg_view.py:3728:1: E305 expected 2 blank lines after class or function definition, found 1
setup.py:20:1: E305 expected 2 blank lines after class or function definition, found 1

@a1exsh
Copy link
Member

a1exsh commented Feb 13, 2017

@kmoppel I find it that often than not that flake8 adds more complaints than it was reporting before. I think we should open a separate PR, then you could update your branch to the recent master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants