Skip to content

Treat 406 from Microsoft as 429 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngoral wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Treat 406 from Microsoft as 429 #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/webpush/request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def verify_response(resp)
raise Unauthorized.new(resp, uri.host)
elsif resp.is_a?(Net::HTTPRequestEntityTooLarge) # 413
raise PayloadTooLarge.new(resp, uri.host)
elsif resp.is_a?(Net::HTTPTooManyRequests) # 429, try again later!
elsif resp.is_a?(Net::HTTPTooManyRequests) || resp.is_a?(Net::HTTPNotAcceptable) # 429, try again later! or 406 from Microsoft
raise TooManyRequests.new(resp, uri.host)
elsif resp.is_a?(Net::HTTPServerError) # 5xx
raise PushServiceError.new(resp, uri.host)
Expand Down
6 changes: 6 additions & 0 deletions spec/webpush_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@
expect { subject }.to raise_error(Webpush::TooManyRequests)
end

it 'raises TooManyRequests if the API returns a 406 Error' do
stub_request(:post, expected_endpoint)
.to_return(status: 406, body: '', headers: {})
expect { subject }.to raise_error(Webpush::TooManyRequests)
end

it 'raises PushServiceError if the API returns a 5xx Error' do
stub_request(:post, expected_endpoint)
.to_return(status: 500, body: '', headers: {})
Expand Down