This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Return-Path Email is not used#215
Open
Filipe-Bicho wants to merge 2 commits intozendframework:masterfrom
Open
Conversation
E-mail Return-Path is not used because it only uses the last forced e-mail address, so this code change gives priority to the e-mail address that is already stored in the parameters and therefore the return path mail will be set correctly.
Ocramius
suggested changes
Aug 14, 2018
Member
Ocramius
left a comment
There was a problem hiding this comment.
This kind of change requires test additions
Member
|
This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#27. |
Member
|
This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
E-mail Return-Path is not set correctly because it only uses the last forced e-mail address, so as workaround I implemented this code change to give priority to the e-mail address that is already stored in the parameters and therefore the return path mail will be set correctly.
E.g. $parameters = " '-f test1@mail.com' '-f test2@mail.com'";
It will use 'test2@mail.com' as return path email.
Magento 2.3.0 Alpha: steps to reproduce