This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Fix AddressList toString method to quote semicolon#230
Open
glensc wants to merge 1 commit intozendframework:masterfrom
Open
Fix AddressList toString method to quote semicolon#230glensc wants to merge 1 commit intozendframework:masterfrom
glensc wants to merge 1 commit intozendframework:masterfrom
Conversation
Contributor
Author
|
@weierophinney, @Xerkus can you take care of this? |
Contributor
Author
|
this is a regression from #147 as it added however, there should not be an assumption that only zend-mail is used for reading writing mail messages. |
glensc
added a commit
to eventum/zend-mail
that referenced
this pull request
Jul 6, 2019
* pr/230: zendframework#230 fix AddressList toString method to quote semicolon
glensc
added a commit
to glensc/eventum
that referenced
this pull request
Jul 6, 2019
Member
|
This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#14. |
Member
|
This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This was referenced Jun 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain input of
AddressListheaders, cannot be converted to string and back to header object because of incorrect quoting:gets incorrectly converted as
but
;is address separator, so it needs to be quoted:The problem I discovered internally when using
Storage\MessagewithHeadersinput, therefore testing that method is included in the unit test: