Updated #39: Use stateless flag from toolkit.ini it is present to override value in $_options array#173
Open
NattyNarwhal wants to merge 5 commits intomasterfrom
Open
Updated #39: Use stateless flag from toolkit.ini it is present to override value in $_options array#173NattyNarwhal wants to merge 5 commits intomasterfrom
NattyNarwhal wants to merge 5 commits intomasterfrom
Conversation
…de value in $_options array. Add to constructor by adding to the array in getOptionalParams. Change default stateless flag to flase in the toolkit.ini to match existing functionality Add second stateless flag for XML toolkit. Check if call is being made from compatibility wrapper and use appropriate stateless flag.
(Calvin edit: Don't add "stateless", fixed this while resolving rebase conflict)
And document it
Otherwise would be breaking change for new installs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #39 for details, originally authored by @Scott-Cam and fixed per Alan's comments since original branch wasn't writeable